Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed target of ament_export_libraries (backport #295) #298

Closed
wants to merge 1 commit into from
Closed

Fixed target of ament_export_libraries (backport #295) #298

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 6, 2024

Since a non-existent library was specified for export, a warning was generated as shown below when building packages that depend on gz_ros2_control.

CMake Warning at /home/ubuntu/ws_gz_ros2_control/install/gz_ros2_control/share/gz_ros2_control/cmake/ament_cmake_export_libraries-extras.cmake:116 (message):
  Package 'gz_ros2_control' exports library 'gz_ros2_control' which couldn't
  be found
Call Stack (most recent call first):
  /home/ubuntu/ws_gz_ros2_control/install/gz_ros2_control/share/gz_ros2_control/cmake/gz_ros2_controlConfig.cmake:41 (include)
  CMakeLists.txt:49 (find_package)

This pull request changes it to export the correct existing target.

This is an automatic backport of pull request #295 done by Mergify.

@TakashiSato @mergify
fixed target of ament_export_libraries (#295)
6476e99 
(cherry picked from commit db4d8b0)

# Conflicts:
#	gz_ros2_control/CMakeLists.txt
@mergify mergify bot added the conflicts label May 6, 2024
@mergify mergify bot requested a review from ahcorde as a code owner May 6, 2024 21:53
@mergify Mergify
Copy link
Contributor Author

mergify bot commented May 6, 2024

Cherry-pick of db4d8b0 has failed:

On branch mergify/bp/humble/pr-295
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit db4d8b0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   gz_ros2_control/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request May 6, 2024
Merged
@ahcorde ahcorde closed this May 6, 2024
@mergify mergify bot deleted the mergify/bp/humble/pr-295 branch May 6, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @TakashiSato